Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid ids in frequencies.csv #77

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

johenglisch
Copy link
Collaborator

@johenglisch johenglisch commented Jan 15, 2025

  • frequencies.csv had invalid ids.
  • I fixed the tests so one can see which dataset an error comes from

Two remarks:

EDIT: I sent a patch: cldf/pycldf#188

@xrotwang
Copy link
Contributor

All cldf data being deleted is typically a sign of an unsuccessful makecldf call - which starts by cleaning out the old cldf data.

@FredericBlum
Copy link
Collaborator

FredericBlum commented Jan 15, 2025

It was a sign of me deleting the cldf-folder due to merge conflicts while working on the release candidate. I was working on a different branch and had to merge a couple of commits that were made by others directly to the master-branch instead of going through PR's, which caused several problems down the line. So we can ignore that for now because I am still preparing that release candidate and will push that through a Pull Request later today, including some last fixes.

Thank @johenglisch for catching the ID issue!

@FredericBlum FredericBlum merged commit fe7e6bf into main Jan 15, 2025
0 of 4 checks passed
@FredericBlum FredericBlum deleted the invalid-ids-in-frequencies branch January 15, 2025 08:51
@johenglisch
Copy link
Collaborator Author

@FredericBlum Robert just made a bugfix release for pycldf. The github actions should pull in the new version automatically but you might want to upgrade pycldf in your venv to make sure pytest validates the data properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants